Ethereum/Tests Migration Guide¶

Overview¶

This guide documents the migration from custom test fixtures to the official ethereum/tests repository. This aligns with TEST-001 and provides better EVM validation coverage.

Current Status¶

Phase 1-2: ✅ Complete¶

JSON parsing infrastructure implemented
Test execution framework working
4 initial validation tests passing

Phase 3: ⏳ In Progress - BLOCKED¶

84 tests passing from ethereum/tests
35 tests failing (mostly gas calculation issues)
Gas calculation discrepancies identified and documented
BLOCKED on EIP-2929 gas calculation fixes

Test Categories¶

Working Tests (84 passing)¶

ValidBlocks/bcValidBlockTest (24/29 passing) - SimpleTx (Berlin, Istanbul) ✅ - ExtraData32 (Berlin, Istanbul) ✅ - dataTx (Berlin, Istanbul) ✅
- RecallSuicidedContract - And 18 more...

ValidBlocks/bcStateTests (60/80 passing) - Various state transition tests - Transaction execution tests - Contract deployment tests

ValidBlocks/bcUncleTest (10/10 passing) ✨ - All uncle validation tests passing

Failing Tests (35 failing)¶

Gas Calculation Issues (multiple tests) - add11 tests - See Gas Calculation Reference - addNonConst tests - EIP-2929 related - Various wallet tests - Gas calculation and state root issues

State Root Mismatches (some tests) - May be related to gas calculation issues - Requires investigation after gas fixes

Mapping Old Tests to New Tests¶

ForksTest.scala → BlockchainTests¶

Old Test: ForksTest.scala - Custom test fixtures for fork validation - Tests Homestead, EIP150, EIP160, EIP155 transitions

New Tests: BlockchainTests/ValidBlocks/* - More comprehensive fork coverage - Community-maintained and validated - Covers same functionality plus more edge cases

Recommendation: 1. Keep ForksTest.scala temporarily for comparison 2. Validate that ethereum/tests covers all ForksTest scenarios 3. Mark ForksTest as deprecated 4. Remove after validation period (1-2 releases)

ContractTest.scala → GeneralStateTests¶

Old Test: ContractTest.scala - Tests contract deployment and execution - Purchase contract example

New Tests: BlockchainTests/GeneralStateTests/* - Thousands of contract tests - Various opcodes and scenarios - State transition validation

Recommendation: 1. Identify specific contract test scenarios in ContractTest 2. Find equivalent ethereum/tests (likely in stCreateTest, stCallCodes, etc.) 3. Mark ContractTest as deprecated 4. Document mapping in comments

ECIP1017Test.scala → Keep (ETC-specific)¶

Status: KEEP - No migration needed

Reason: - ETC-specific monetary policy (ECIP-1017) - Not covered by ethereum/tests (ETH-only) - Critical for ETC consensus - No equivalent in ethereum/tests

Migration Strategy¶

Phase 1: Validation (Current)¶

✅ Run ethereum/tests alongside existing tests
✅ Verify coverage of existing scenarios
✅ Identify gaps or missing tests
🔴 Fix gas calculation issues - BLOCKING

Phase 2: Deprecation (After gas fixes)¶

Mark old tests as deprecated
Add comments referencing ethereum/tests equivalents
Update documentation

Phase 3: Removal (Future - 1-2 releases)¶

Remove deprecated tests
Keep ECIP1017Test
Full migration to ethereum/tests

Test Execution¶

Running Individual Tests¶

# Run simple validation tests
sbt "it:testOnly com.chipprbots.ethereum.ethtest.SimpleEthereumTest"

# Run blockchain tests
sbt "it:testOnly com.chipprbots.ethereum.ethtest.BlockchainTestsSpec"

# Run comprehensive test suite (84 tests)
sbt "it:testOnly com.chipprbots.ethereum.ethtest.ComprehensiveBlockchainTestsSpec"

# Run gas calculation analysis
sbt "it:testOnly com.chipprbots.ethereum.ethtest.GasCalculationIssuesSpec"

Running All Integration Tests¶

sbt "it:test"

Test File Organization¶

Resources Directory¶

src/it/resources/ethereum-tests/
├── SimpleTx.json           # Basic value transfer (Berlin, Istanbul)
├── ExtraData32.json        # Extra data validation
├── dataTx.json             # Transaction with data
├── add11.json              # ⚠️ Failing - gas issue
└── addNonConst.json        # ⚠️ Failing - gas issue

Test Specs¶

src/it/scala/com/chipprbots/ethereum/ethtest/
├── EthereumTestsSpec.scala              # Base class
├── SimpleEthereumTest.scala             # 4 validation tests ✅
├── BlockchainTestsSpec.scala            # 6 focused tests ✅
├── GeneralStateTestsSpec.scala          # ⚠️ 2 failing (gas issues)
├── ComprehensiveBlockchainTestsSpec.scala # 84 passing tests ✅
└── GasCalculationIssuesSpec.scala       # Analysis tool

Network Support¶

Supported Networks (Pre-Spiral)¶

All tests filtered to only run on supported networks: - Frontier - Homestead - EIP150 (Tangerine Whistle) - EIP158 (Spurious Dragon) - Byzantium - Constantinople - Istanbul - Berlin

Unsupported Networks (Post-Spiral)¶

Tests for these networks are automatically filtered out: - London - Paris - Shanghai - Cancun - Any future forks

Known Issues¶

🔴 Critical: Gas Calculation¶

Status: RESOLVED

See Gas Calculation Reference for full details.

Summary: - EIP-2929 gas costs verified correct - Fork configuration fixed for Berlin tests - Gas metering now Ethereum-compliant

State Root Mismatches¶

Status: Under investigation

Some tests show state root mismatches. May be related to: - Gas calculation issues (affects state) - Storage handling - Account state updates

Test Coverage Goals¶

Minimum (Current - BLOCKED)¶

✅ 50+ tests passing - ACHIEVED: 84 tests
🔴 No gas calculation errors - NOT MET
✅ Multiple test categories - ACHIEVED

Target (After gas fixes)¶

100+ tests passing
< 5% failure rate
All critical path scenarios covered

Stretch (Future)¶

500+ tests passing
< 1% failure rate
Full ethereum/tests coverage for supported networks

CI Integration (Blocked)¶

Status: Cannot proceed until gas calculation is fixed

Planned:

# .github/workflows/ethereum-tests.yml
name: Ethereum Tests

on: [pull_request, push]

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          submodules: recursive

      - name: Run Ethereum Tests
        run: sbt "it:test"

      - name: Check Gas Calculation
        run: sbt "it:testOnly com.chipprbots.ethereum.ethtest.GasCalculationIssuesSpec"
        # Should fail if gas issues exist

References¶

Contributing¶

Adding New Test Files¶

Copy test from ets/tests/ to src/it/resources/ethereum-tests/
Add test case to appropriate spec file
Run test and verify it passes
Update this migration guide

Debugging Test Failures¶

Run specific test with detailed logging
Check gas calculations using GasCalculationIssuesSpec
Compare with reference implementation (geth)
Document findings

Last Updated: November 15, 2025
Status: Phase 3 In Progress - BLOCKED on gas calculation fixes
Next Action: Fix EIP-2929 gas calculation issues